support zstd and deflate auto compression #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjsaunier
requested changes
Jan 24, 2025
scrapfly/extraction_config.py
Outdated
| """ | ||
|
|
||
| if len(data) < 2: | ||
| return 'unknown' |
scrapfly/extraction_config.py
Outdated
|
|
||
| # gzip | ||
| if data[0] == 0x1f and data[1] == 0x8b: | ||
| return 'gzip' |
Member
There was a problem hiding this comment.
We can directly use the CompressionFormatEnum, remove the translation between string to enum and add a return type accordingly
scrapfly/extraction_config.py
Outdated
| ] | ||
| for magic in zstd_magic_numbers: | ||
| if data[:len(magic)] == magic: | ||
| return 'zstd' |
scrapfly/extraction_config.py
Outdated
| # deflate | ||
| if data[0] == 0x78: | ||
| if data[1] in (0x01, 0x5E, 0x9C, 0xDA): | ||
| return 'deflate' |
jjsaunier
approved these changes
Jan 24, 2025
jjsaunier
pushed a commit
that referenced
this pull request
Jan 24, 2025
* add config serialization/deserialization support * fix wrong types on config conversion * support zstd and deflate auto compression (#29) * support zstd and deflate auto compression * add auto compression detection support * update auto compression detection * use enums directly * remove debugging line and update method singature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.